chore: salesforce for Router / Booker atoms and api v2#19217
chore: salesforce for Router / Booker atoms and api v2#19217ThyMinimalDev merged 12 commits intomainfrom
Conversation
keithwillcode
added
core
dosubot
Bot
added
the
crm-apps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| if ( | ||
| routingSearchParams.get("cal.action") === "eventTypeRedirectUrl" && | ||
| routingSearchParams.has("email") && | ||
| routingSearchParams.has("cal.teamId") | ||
| ) { | ||
| return this.handleEventTypeRedirect(routingUrl, routingSearchParams); | ||
| } |
There was a problem hiding this comment.
if team eventtype redirect url, check if we need to get salesforce param
| email: teamMemberEmail, | ||
| recordType: crmOwnerRecordType, | ||
| crmAppSlug, | ||
| } = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({ |
There was a problem hiding this comment.
@joeauyeung can you confirm when should this function be called ?
| ...(routingSearchParams.get("cal.teamMemberEmail") && { | ||
| teamMemberEmail: routingSearchParams.get("cal.teamMemberEmail") ?? undefined, | ||
| }), | ||
| ...(routingSearchParams.get("cal.crmOwnerRecordType") && { | ||
| crmOwnerRecordType: routingSearchParams.get("cal.crmOwnerRecordType") ?? undefined, | ||
| }), | ||
| ...(routingSearchParams.get("cal.crmAppSlug") && { | ||
| crmAppSlug: routingSearchParams.get("cal.crmAppSlug") ?? undefined, | ||
| }), |
There was a problem hiding this comment.
add props concerning salesforce
| teamMemberEmail={teamMemberEmail} | ||
| crmOwnerRecordType={crmOwnerRecordType} | ||
| crmAppSlug={crmAppSlug} |
There was a problem hiding this comment.
give props concerning salesforce to the booker
| rest.routedTeamMemberIds, | ||
| rest.skipContactOwner, | ||
| rest.shouldServeCache, | ||
| rest.teamMemberEmail, |
There was a problem hiding this comment.
team member email from salesforce
| crmAppSlug, | ||
| isSEOIndexable: allowSEOIndexing, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
refactored for clarity
joeauyeung
left a comment
joeauyeung
left a comment
There was a problem hiding this comment.
Had a call with @ThyMinimalDev. Logic makes sense and we're passing the right params. Will approve.
| routingSearchParams.get("cal.action") === "eventTypeRedirectUrl" && | ||
| routingSearchParams.has("email") && | ||
| routingSearchParams.has("cal.teamId") && | ||
| !routingSearchParams.has("cal.skipContactOwner") |
There was a problem hiding this comment.
if skipContactOwner is defined, no need to check with salesforce
| email: teamMemberEmail, | ||
| recordType: crmOwnerRecordType, | ||
| crmAppSlug, | ||
| } = await getTeamMemberEmailForResponseOrContactUsingUrlQuery({ |
There was a problem hiding this comment.
in a follow up pr, we can try to create a new function that would merge the logic of getting the routed url and the contact owner in a more optimised fashion
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. What is a typosquat?Package name is similar to other popular packages and may not be the package you want. Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
E2E results are ready! |
* wip * small refactor * small refactor * fixup! Merge branch 'main' into enable-salesforce-router-apiv2-atom * crm props * fixup! crm props * bump platform libraries * bump platform libraries
4 participants
What does this PR do?
add salesforce support
Mandatory Tasks (DO NOT REMOVE)