fix: UI breaks with too many email adresses#19610
Closed
harshit078 wants to merge 2 commits intocalcom:mainfrom
Closed
fix: UI breaks with too many email adresses#19610harshit078 wants to merge 2 commits intocalcom:mainfrom
harshit078 wants to merge 2 commits intocalcom:mainfrom
Conversation
|
@harshit078 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
Low priority
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/27/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (02/27/25)1 label was added to this PR based on Keith Williams's automation. |
Udit-takkar
reviewed
Feb 27, 2025
| handleVerifyEmail={() => handleResendVerifyEmail(field.email)} | ||
| handleItemDelete={() => deleteSecondaryEmail(index)} | ||
| /> | ||
| ))} |
Contributor
There was a problem hiding this comment.
in L687 there is secondaryEmailFields.map again. do we need both?
Contributor
|
hey @harshit078 thank you for your PR 🙏 this was fixed earlier with #19584 and #19602 ! closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevented container overflow when no of emails exceeded a certain limit. Added scroll behaviour to control the overflow and enhance the user interface.
Visual Demo
Screen.Recording.2025-02-28.at.12.40.09.AM.mov
Mandatory Tasks (DO NOT REMOVE)