Skip to content

Let users set 12/24 hour time format#2002

Merged
pumfleet merged 1 commit intomainfrom
dashboard-time-format
Feb 28, 2022
Merged

Let users set 12/24 hour time format#2002
pumfleet merged 1 commit intomainfrom
dashboard-time-format

Conversation

@pumfleet
Copy link
Copy Markdown
Contributor

What does this PR do?

Add a new timeFormat field to the user which lets you set 12/24 hour time format in the dashboard. It updates the booking page, availability page and getting started page to use the new time format. It also adds it as an extra field in settings.

Closes #1990

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Run migration
  • Update time format in settings
  • Check relevant pages in the app to see that the format is correct

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't checked if my PR needs changes to the documentation
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/6jgFoVPDV8Kt8PfsjyTREhfsmNr9
✅ Preview: Canceled

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/C3XVeYWCxKmrT4wcooKUBaJMb8ov
✅ Preview: https://calendso-git-dashboard-time-format-cal.vercel.app

@PeerRich PeerRich added the ✨ feature New feature or request label Feb 28, 2022
@PeerRich PeerRich added this to the v.1.4 milestone Feb 28, 2022
@agustif
Copy link
Copy Markdown
Contributor

agustif commented Feb 28, 2022

Looks good to me, just added a small DRY nitpick not really important. awesome thanks Bailey

@pumfleet pumfleet merged commit 7826a34 into main Feb 28, 2022
@pumfleet pumfleet deleted the dashboard-time-format branch February 28, 2022 16:24
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only ✨ feature New feature or request

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Support for 12 and 24 hour time formats on the dashboard

3 participants