fix: Incorrect RR host is shown in the email and calendar event for a seated RR event#21684
Conversation
|
@anikdhabal is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/03/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (06/11/25)1 label was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
cubic found 2 issues across 1 file. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
| if (originalNonFixedHost) { | ||
| users = [...fixedHosts, originalNonFixedHost]; |
There was a problem hiding this comment.
For seated events, ensure host consistency across all remaining seats
| } else { | ||
| const attendeeEmailSet = new Set(booking.attendees.map((attendee) => attendee.email)); | ||
|
|
||
| // In this case, the first booking user is a fixed host, so the chosen non-fixed host is added as an attendee of the booking | ||
| const nonFixedAttendeeHosts = users.filter( |
There was a problem hiding this comment.
When both fixed and non-fixed hosts are set for a round-robin event, the selected round-robin host is added as an attendee, and one of the fixed hosts becomes the organizer of the event.
To maintain consistency, we determine the round-robin host from the attendee record for the remaining seats
E2E results are ready! |
… seated RR event (calcom#21684) * fix: seated rr event * Update packages/features/bookings/lib/handleNewBooking.ts Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * update * Update handleNewBooking.ts --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
What does this PR do?
Summary by cubic
Fixed an issue with seated round robin events where non-fixed hosts were not correctly assigned as booking users or attendees. This ensures bookings reflect the correct host assignments for round robin scheduling.