Skip to content

cleanup(test): remove team duration limit integration coverage#29015

Merged
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-team-duration-limits-integration-test
Apr 26, 2026
Merged

cleanup(test): remove team duration limit integration coverage#29015
romitg2 merged 1 commit intocalcom:mainfrom
romitg2:cleanup/remove-team-duration-limits-integration-test

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Apr 26, 2026

What this does

  • removes the dedicated team round-robin duration-limit integration test
  • drops schedule availability coverage that depends on team events

Verification

yarn type-check:ci --force

The command passed locally.

@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "cleanup" found in pull request title "cleanup(test): remove team duration limit integration coverage". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 added ready-for-e2e run-ci Approve CI to run for external contributors labels Apr 26, 2026
@romitg2 romitg2 marked this pull request as ready for review April 26, 2026 18:33
@romitg2 romitg2 enabled auto-merge (squash) April 26, 2026 18:33
@romitg2 romitg2 requested a review from sahitya-chandra April 26, 2026 18:33
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f9617750-1f3b-41ae-9b80-f0436d1ac80b

📥 Commits

Reviewing files that changed from the base of the PR and between 57586ba and 750af62.

📒 Files selected for processing (1)
  • apps/web/test/lib/getSchedule/durationLimits.integration-test.ts
💤 Files with no reviewable changes (1)
  • apps/web/test/lib/getSchedule/durationLimits.integration-test.ts

📝 Walkthrough

Walkthrough

This pull request removes an integration test file that validated duration limit enforcement in event scheduling. The test created a multi-user setup with a team, schedules, and an event type configured with a yearly duration limit of 480 minutes and round-robin scheduling. It seeded accepted bookings totaling 400 minutes across different dates, advanced time to February 2026, and verified that getAvailableSlots() correctly disabled date slots when the yearly duration limit was reached. The file contained 213 lines of test code and cleanup logic.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'cleanup(test): remove team duration limit integration coverage' directly and specifically describes the main change: deletion of a team duration limit integration test file.
Description check ✅ Passed The description is directly related to the changeset, explaining why the test file was removed and providing verification that type-checking passed locally.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@romitg2 romitg2 merged commit ec1ff7e into calcom:main Apr 26, 2026
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-e2e run-ci Approve CI to run for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants