Skip to content

cleanup(workspace-platform): remove entrypoints#29035

Merged
romitg2 merged 3 commits intocalcom:mainfrom
romitg2:cleanup/remove-workspace-platform-entrypoints
May 1, 2026
Merged

cleanup(workspace-platform): remove entrypoints#29035
romitg2 merged 3 commits intocalcom:mainfrom
romitg2:cleanup/remove-workspace-platform-entrypoints

Conversation

@romitg2
Copy link
Copy Markdown
Member

@romitg2 romitg2 commented Apr 26, 2026

What this does

  • removes the dead workspace-platform settings redirect from apps/web/next.config.ts
  • removes the placeholder /auth/platform/authorize route and its module
  • removes the signup special-case redirect into /settings/platform/new
  • removes shell and user-dropdown checks that only existed for the missing /settings/platform pages

Verification

yarn vitest run apps/web/modules/shell/user-dropdown/UserDropdown.test.tsx
yarn type-check:ci --force

Result

  • apps/web/modules/shell/user-dropdown/UserDropdown.test.tsx passed
  • yarn type-check:ci --force passed

@romitg2 romitg2 added ready-for-e2e run-ci Approve CI to run for external contributors labels Apr 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 26, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "cleanup" found in pull request title "cleanup(workspace-platform): remove entrypoints". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@romitg2 romitg2 marked this pull request as ready for review April 30, 2026 16:34
@romitg2 romitg2 enabled auto-merge (squash) April 30, 2026 16:34
@romitg2 romitg2 requested a review from sahitya-chandra April 30, 2026 16:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 56783067-a5cc-4f4e-9316-96313a7487d2

📥 Commits

Reviewing files that changed from the base of the PR and between 1591a50 and a356ded.

📒 Files selected for processing (8)
  • apps/web/app/(use-page-wrapper)/auth/platform/authorize/page.tsx
  • apps/web/modules/auth/platform/authorize-view.tsx
  • apps/web/modules/shell/Shell.tsx
  • apps/web/modules/shell/SideBar.tsx
  • apps/web/modules/shell/user-dropdown/UserDropdown.test.tsx
  • apps/web/modules/shell/user-dropdown/UserDropdown.tsx
  • apps/web/modules/signup-view.tsx
  • apps/web/next.config.ts
💤 Files with no reviewable changes (5)
  • apps/web/next.config.ts
  • apps/web/modules/shell/user-dropdown/UserDropdown.test.tsx
  • apps/web/app/(use-page-wrapper)/auth/platform/authorize/page.tsx
  • apps/web/modules/auth/platform/authorize-view.tsx
  • apps/web/modules/signup-view.tsx

📝 Walkthrough

Walkthrough

This change removes the platform authorization feature from the application. It deletes the authorization page and its associated view component, removes platform-specific prop plumbing from shell layout components, eliminates platform user detection based on route inspection, removes platform-specific menu items from the user dropdown, and simplifies signup redirect logic by removing platform-specific branching. A redirect rule for platform settings routes is also removed from the Next.js configuration.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing workspace-platform entrypoints, which aligns with the changeset's deletion of related routes, modules, and conditional logic.
Description check ✅ Passed The description is directly related to the changeset, providing specific details about what was removed (redirect rules, routes, modules, and conditional checks) and including verification steps that passed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@romitg2 romitg2 merged commit 9cd1f34 into calcom:main May 1, 2026
63 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-e2e run-ci Approve CI to run for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants