Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Contributor
Author
|
@leog I had a look at dayjs-recur but I would say (looking at both repo's) that rrule is better. Recur is a dead project (last activity was in March) - and has a total of 8 stars. It also only supports a very limited subset of features compared to rrule - and also very importantly rrule is a port of the python project for recurring rules which is good for debugging (you can use python docs to learn about rrule.js features). Rrule also has some bugs that need fixing but the performance issues we've been seeing can be resolved on our end. It's a much more stable project. |
Contributor
|
Ok, I agree, thanks @emrysal for the insight. |
2 tasks
Added an extra seeded example for recurring
Udit-takkar
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Structural fix to recurring times * Remove conversion regression * Revert current time -> startTime based utcOffset * Fixing remaining events count * Using user's preference for recurring tooltip * Missing refactor * Showing better datetime in booking page Added an extra seeded example for recurring Co-authored-by: Leo Giovanetti <hello@leog.me>
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* Structural fix to recurring times * Remove conversion regression * Revert current time -> startTime based utcOffset * Fixing remaining events count * Using user's preference for recurring tooltip * Missing refactor * Showing better datetime in booking page Added an extra seeded example for recurring Co-authored-by: Leo Giovanetti <hello@leog.me>
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
* Structural fix to recurring times * Remove conversion regression * Revert current time -> startTime based utcOffset * Fixing remaining events count * Using user's preference for recurring tooltip * Missing refactor * Showing better datetime in booking page Added an extra seeded example for recurring Co-authored-by: Leo Giovanetti <hello@leog.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the DST issues regarding recurring events.
Also, it fixes a couple of issues:
"events remaining" on recurring events now reflect past events within the series
Booking page was not applying user's preferences to display time
