Hotfix/Embed: Theming not working#5976
Merged
kodiakhq[bot] merged 1 commit intomainfrom Dec 12, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
There should be a test to verify that theme has been applied successfully. The test can simply check if light/dark classes are applied on document. |
hariombalhara
changed the title
hariombalhara
added
♻️ autoupdate
JeroenReumkens
approved these changes
Dec 12, 2022
hariombalhara
added a commit
that referenced
this pull request
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5978
Embed UI Instruction shouldn't depend on plan now as everyone is at least PRO.
Environment: Production
Type of change