fix: use hasMounted to render calcom versionm#6239
Merged
Conversation
Signed-off-by: Udit Takkar <udit.07814802719@cse.mait.ac.in>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
i bet there is a better workaround. if not we should move this into a standalone component to prevent repeating code |
Member
|
i think by turning the constant into a react component, it would not have hydration issues. wanna try that? |
Member
|
PeerRich
requested changes
Jan 2, 2023
PeerRich
approved these changes
Jan 2, 2023
Member
PeerRich
left a comment
There was a problem hiding this comment.
made some changes, created <Credits>
Member
|
@Udit-takkar can you investigate why checks are failing? |
PeerRich
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Hydration error in /event-types page
Ref: https://www.joshwcomeau.com/react/the-perils-of-rehydration/#the-solution
Environment: Staging(main branch) / Production
Type of change