chore: Rounding, frames and radio buttons of the booking forms not consistent#8705
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Twelve Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Current Playwright Test Results Summary✅ 104 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/30/2023 03:43:35pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 59236cf Started: 05/30/2023 03:39:08pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests user -- new-booker can add multiple organizer address
Retry 1 • Initial Attempt |
2.30% (9)9 / 392 runsfailed over last 7 days |
11.48% (45)45 / 392 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
2.78% (4)4 / 144 runsfailed over last 7 days |
65.28% (94)94 / 144 runsflaked over last 7 days |
sean-brydon
left a comment
There was a problem hiding this comment.
Thanks @gitstart-calcom we need to use our tokens in this so our colours are consitant throughout the app.
I've not visually reviewed this so i dont know the classes are correct. Please use our brand class names to style with the users brand colors.
If youre more intrested in how this works look at our figma or take a look at cal.com/packages/config/tailwind-preset.js to see all of our available tokens <3
2738510 to
5675255
Compare
Hi @zomars, what do you think? |
JeroenReumkens
left a comment
There was a problem hiding this comment.
Great changes @gitstart-calcom! I approved them 🙏

Fixes #7508
Demo
https://www.loom.com/share/f020b84243ca48928f6d44d8b9df6f92
Steps to reproduce:
FIgma with the updated design: https://www.figma.com/file/9MOufQNLtdkpnDucmNX10R/%E2%9D%96-Cal-DS?node-id=309-44674&t=XVOdTk8kjKnXp6ti-0