fix: Booking Page crash with prefilling guests#9566
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hariombalhara
force-pushed
the
fix/new-booker-crash-with-guests-prefill
branch
from
df9da50 to
f806bba
Compare
hariombalhara
commented
Jun 16, 2023
hariombalhara
changed the title
emrysal
approved these changes
Jun 16, 2023
Contributor
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 98 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 06/16/2023 12:25:37pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: cc3061b Started: 06/16/2023 12:23:18pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully login flow user & logout using dashboard
Retry 2 • Retry 1 • Initial Attempt |
5.54% (15)15 / 271 runsfailed over last 7 days |
28.41% (77)77 / 271 runsflaked over last 7 days |
iamr-kumar
pushed a commit
to iamr-kumar/cal.com
that referenced
this pull request
Jun 18, 2023
* Fix Booking Page crash with prefilling guests * Update packages/features/bookings/Booker/components/BookEventForm/BookEventForm.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes new booker crash when guests are prefilled.
This PR borrows the code from https://github.com/calcom/cal.com/pull/8671/files?diff=unified#r1185081708(a low priority PR which had this fix)
Before:
https://www.loom.com/share/6a223160687c4f52a2c16a1a6e5342af
After:
https://www.loom.com/share/0e362bac6d044b5ba74653975155ce95?from_recorder=1&focus_title=1
Type of change
How should this be tested?
Mandatory Tasks
Checklist