fix: Slot reservation in new booker by roae · Pull Request #9769 · calcom/cal.diy

roae · 2023-06-24T03:17:10Z

What does this PR do?

Bring back the slot reservation sistem to the new booker

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Seated event

Open the new booker in an event with seats
Select an available slot
Open the same event and date in other browser, the seat should be already reserved.
In the first browser come back to the slots views or close the booking form
In the second browser reload the booking page, the reserved slot should be realeased.

No seated event

Open the new booker
Select an available slot
Open the same event and date in other browser, the seat should be disabled

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

vercel · 2023-06-24T03:17:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2023 7:22pm
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2023 7:22pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2023 7:22pm
web-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2023 7:22pm

github-actions · 2023-06-24T03:17:24Z

Thank you for following the naming conventions! 🙏

roae · 2023-06-24T03:19:07Z

+  useEffect(() => {
+    reserveSlot();
+    const interval = setInterval(reserveSlot, parseInt(MINUTES_TO_BOOK) * 60 * 1000 - 2000);
+    return () => {
+      if (eventType) {
+        releaseSlotMutation.mutate();
+        clearInterval(interval);
+      }
+    };
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [eventType]);


reserve the slot on the booking form mount, and release on unmount the component

github-actions · 2023-06-24T03:27:56Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

joeauyeung

@roae reserving slots should be disabled for seated events except for the last seat. Here's a link to what I've done. Could you address this in your PR?

https://github.com/calcom/cal.com/pull/9778/files#r1240959003

roae · 2023-06-25T03:13:21Z

@roae reserving slots should be disabled for seated events except for the last seat. Here's a link to what I've done. Could you address this in your PR?

https://github.com/calcom/cal.com/pull/9778/files#r1240959003

Hey @joeauyeung I believe this is how it works, when select an available slot in an seated event the number of available seats should decrease

joeauyeung · 2023-06-25T17:17:49Z

@roae reserving slots should be disabled for seated events except for the last seat. Here's a link to what I've done. Could you address this in your PR?
https://github.com/calcom/cal.com/pull/9778/files#r1240959003

Hey @joeauyeung I believe this is how it works, when select an available slot in an seated event the number of available seats should decrease

We found that the reserve system was creating bugs with seats when multiple people tried signing up.

For example, a customer sent an email blast about an event. This caused a big spike in people trying to sign up for the booking, but the reserve system was blocking multiple people trying to book the event at the same time even though there were seats available.

I think if there are multiple seats available we don't need to reserve that slot.

roae · 2023-06-25T21:12:35Z

@roae reserving slots should be disabled for seated events except for the last seat. Here's a link to what I've done. Could you address this in your PR?
https://github.com/calcom/cal.com/pull/9778/files#r1240959003

Hey @joeauyeung I believe this is how it works, when select an available slot in an seated event the number of available seats should decrease

We found that the reserve system was creating bugs with seats when multiple people tried signing up.

For example, a customer sent an email blast about an event. This caused a big spike in people trying to sign up for the booking, but the reserve system was blocking multiple people trying to book the event at the same time even though there were seats available.

I think if there are multiple seats available we don't need to reserve that slot.

Ok!, I get it

ericrommel · 2023-06-26T15:43:23Z

@roae @joeauyeung I'm seeing a different text from what the screenshot in the description has. Could you please confirm which one is correct?

roae · 2023-06-26T19:09:10Z

@roae @joeauyeung I'm seeing a different text from what the screenshot in the description has. Could you please confirm which one is correct?

Hey @ericrommel both are correct, My screenshot show text in spanish

ericrommel · 2023-06-26T19:11:27Z

@roae @joeauyeung I'm seeing a different text from what the screenshot in the description has. Could you please confirm which one is correct?

Hey @ericrommel both are correct, My screenshot show text in spanish

@roae, I'm talking about the numbers there. Your screenshot shows "2 seats available" and my one shows "2 / 3 seats available".

roae · 2023-06-26T19:26:56Z

@roae @joeauyeung I'm seeing a different text from what the screenshot in the description has. Could you please confirm which one is correct?

Hey @ericrommel both are correct, My screenshot show text in spanish

@roae, I'm talking about the numbers there. Your screenshot shows "2 seats available" and my one shows "2 / 3 seats available".

yes there are differences in the translation.
could you ask in threads?, I think both are correct, lets disscuss this with @Jaibles

ericrommel

Everything looks great from my tests.

To be followed up

zomars

Code LGTM. Let's address seated events in a follow up.

## What does this PR do? Bring back the slot reservation sistem to the new booker ## Type of change  - Bug fix (non-breaking change which fixes an issue) ## How should this be tested?  ### Seated event - [x] Open the new booker in an event with seats - [x] Select an available slot - [x] Open the same event and date in other browser, the seat should be already reserved. - [x] In the first browser come back to the slots views or close the booking form - [x] In the second browser reload the booking page, the reserved slot should be realeased. ### No seated event - [x] Open the new booker - [x] Select an available slot - [x] Open the same event and date in other browser, the seat should be disabled ## Mandatory Tasks - [x] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

roae added 2 commits June 23, 2023 19:06

Reserve and release the slot when the booking form show or hide

192b217

fix skipBatch

d78cbc7

roae requested review from CarinaWolli, hariombalhara and sean-brydon June 24, 2023 03:17

roae commented Jun 24, 2023

View reviewed changes

Merge branch 'main' into fix/slot-reservation-in-new-booker

c2965d1

vercel Bot deployed to Preview – cal June 24, 2023 03:26 View deployment

vercel Bot deployed to Preview – api June 24, 2023 03:26 View deployment

vercel Bot deployed to Preview – web-staging June 24, 2023 03:29 View deployment

joeauyeung mentioned this pull request Jun 24, 2023

fix: seats regression [CAL-2041] #9778

Merged

10 tasks

joeauyeung previously requested changes Jun 24, 2023

View reviewed changes

PeerRich requested a review from a team June 25, 2023 15:04

PeerRich added the High priority Created by Linear-GitHub Sync label Jun 25, 2023

PeerRich assigned ericrommel Jun 25, 2023

Merge branch 'main' into fix/slot-reservation-in-new-booker

1bce131

vercel Bot deployed to Preview – ui June 26, 2023 19:13 View deployment

vercel Bot deployed to Preview – api June 26, 2023 19:14 View deployment

vercel Bot deployed to Preview – cal June 26, 2023 19:17 View deployment

vercel Bot deployed to Preview – web-staging June 26, 2023 19:22 View deployment

ericrommel approved these changes Jun 26, 2023

View reviewed changes

zomars approved these changes Jun 27, 2023

View reviewed changes

zomars merged commit 04ed36c into main Jun 27, 2023

zomars deleted the fix/slot-reservation-in-new-booker branch June 27, 2023 23:34

Conversation

roae commented Jun 24, 2023 • edited by ericrommel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Seated event

No seated event

Mandatory Tasks

Uh oh!

vercel Bot commented Jun 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roae Jun 24, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

joeauyeung left a comment

Choose a reason for hiding this comment

Uh oh!

roae commented Jun 25, 2023

Uh oh!

joeauyeung commented Jun 25, 2023

Uh oh!

roae commented Jun 25, 2023

Uh oh!

ericrommel commented Jun 26, 2023

Uh oh!

roae commented Jun 26, 2023

Uh oh!

ericrommel commented Jun 26, 2023

Uh oh!

roae commented Jun 26, 2023

Uh oh!

ericrommel left a comment

Choose a reason for hiding this comment

Uh oh!

zomars left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roae commented Jun 24, 2023 •

edited by ericrommel

Loading

vercel Bot commented Jun 24, 2023 •

edited

Loading

github-actions Bot commented Jun 24, 2023 •

edited

Loading

github-actions Bot commented Jun 24, 2023 •

edited

Loading