Temporary fix to a big f up

[shrutiiiyet]

Summary by CodeRabbit

• Bug Fixes

  • Improved user account handling to ensure all linked account providers are recognized, not just those using credentials.
  • Corrected a route path typo to ensure accurate API endpoint access.

• Refactor

  • Adjusted internal handling of member creation to streamline input processing. No changes to user-facing functionality.
  • Updated routing to use externally provided database clients, enhancing modularity without affecting functionality.

• Documentation

  • Enhanced API documentation for completed questions to provide detailed information about each question's attributes.

[coderabbitai]

Walkthrough

This change updates the parameter order for the createMember function in both the controller and service layers, moving the provider argument earlier in the list. Additionally, the getUserByEmail function no longer filters accounts by provider, instead selecting all related account providers. The supabase instance usage was refactored in routes to be passed as a parameter rather than imported directly. API documentation for completed questions in progress routes was expanded.

Changes

Cohort / File(s)	Change Summary
Controller update: argument order & query params src/controllers/member.controller.ts	Changed the order of arguments passed to memberService.createMember, moving provider earlier in the list; modified query parameter extraction and validation in listAllApprovedMembers; removed unused import.
Service updates: argument order & query src/services/member.service.ts	Moved password earlier in the createMember parameter list; updated getUserByEmail to select all account providers instead of filtering by 'credentials'.
Route refactor: supabase client injection src/routes/members.ts, src/routes/achievements.ts	Removed direct import of supabase instance; in members route, supabase client is now passed as a parameter to the router function.
API documentation enhancement src/routes/progress.ts	Expanded API documentation for GET /progress/:memberId/completed-questions endpoint to detail the structure of completedQuestion response objects; fixed typo in PATCH route path parameter.

Sequence Diagram(s)

sequenceDiagram
    participant Controller
    participant MemberService
    Controller->>MemberService: createMember(email, name, provider, password?, passoutYear?, imageUrl?)
    MemberService-->>Controller: Member created

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• fixed password import issue #19: Modifies getUserByEmail and updates its usage in the controller, similar to this PR's adjustments.
• Added conditional routing to get approved members route #18: Alters createAMember and createMember argument order and inclusion, directly related to the changes here.
• updated member routes #15: Introduces the original controller and service functions now being modified in this PR.

Suggested reviewers

• i-am-that-guy

Poem

A hop and a skip, parameters shift,
Provider moves up—what a nifty gift!
No more filtering, all accounts in sight,
The code’s now tidy, the order just right.
With every review, this rabbit will cheer—
Bugs hop away, and clarity’s here! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 982cc4f and 805f3ca.

📒 Files selected for processing (1)

• src/routes/progress.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/routes/progress.ts

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch minor-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🔭 Outside diff range comments (1)

src/routes/progress.ts (1)

50-50: Fix typo in route parameter.

There's a typo in the route path parameter: memeberId should be memberId to match the documentation and maintain consistency.

-    "/:memeberId/questions/:questionId/completed/toggle",
+    "/:memberId/questions/:questionId/completed/toggle",

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 19945d9 and 982cc4f.

📒 Files selected for processing (4)

• src/controllers/member.controller.ts (2 hunks)
• src/routes/achievements.ts (0 hunks)
• src/routes/members.ts (0 hunks)
• src/routes/progress.ts (1 hunks)

💤 Files with no reviewable changes (2)

• src/routes/achievements.ts
• src/routes/members.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/controllers/member.controller.ts