Fix: Incorrect note is deleted & opened #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #16
It removes the off-by-one error in the ID system of the notes collection.
Just like described in the issue, the off-by-one error was caused by the modified approach to storing the notes in the application in-memory repository.
This error occurred when a note with given ID was deleted, but notes were then moved by one in the storage, so the last note (with the highest ID and index in the repository) was lost as the size was matching the ID.
To fix that error and to make the system consequent the ID is completely removed from the Notes storage mechanism. It is redundant and the index of a newly created note is just enough to keep them organized and to handle correct displaying and pages navigation/transition.
NOTE: During the fixing the lack of logo in the details page was noticed - the logo is added within this delivery.