Windows accessibility - code architecture & layout adjustments#31
Merged
BartoszKlonowski merged 4 commits intomainfrom Jul 14, 2021
Merged
Conversation
The `Name` property is used to control the item of a XAML layout in the code-behind of a Page. Thsi way it is possible to set its style and properties when they are changed in the Settings.
When text size changes and the font is replaced, the text needs to have enough space to fit in the layout after Settings. To do that some `styles` have been modified to let the text adjust easily to Settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request closes #30
It delivers changes to the layout and architecture solution to make the application be possible for connection with the Settings of Windows OS.
The changes are:
Settings of the application can be connected with those in the Windows OS, so each change (no matter if in settings screen on Windows settings) should be available immediately.
This change also improves the application performance as it gets rid of too many callbacks issue.
Sometimes when text size is changed in the Windows settings, the text in the application can stop fitting into the layout making application to look bad.
To ensure that text will fit always, the
stylesare mostly changed.More information in the commit messages.
Why is the text on buttons still not visible enough?
That is because I used
<Button/>instead of<TouchableHighlight/>and buttons offer much less flexibility and customization than other clickable widgets. Changing that would require more time than I have currently.