You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split the 5.7k-line session handler test into focused scenario files backed by a shared mock harness, so each touched session file stays under 800 lines.
Split Apple app operations out of core/apps.ts into focused launch, install, resolution/inventory, settings, device I/O, and simctl helper modules while keeping core/apps.ts as the stable facade.
Ran the newly split session-handler suites: 11 files, 124 tests passed.
Ran Apple app-focused unit coverage for open/close/install/reinstall/resolve/deep-link/settings cases: 47 tests passed.
Ran provider lifecycle scenarios for iOS and macOS open/apps/appstate behavior: 2 files, 5 tests passed.
Ran pnpm format and pnpm check:quick.
Residual risk: the full src/platforms/apple/core/tests/index.test.ts suite still contains unrelated screenshot/status-bar cases that timed out or attempted xcrun outside the app split. The app-focused subset above passed.
The reason will be displayed to describe this comment to others. Learn more.
Review: LGTM. The monolith actually dissolved: session.test.ts is gone (12+ scenario files, all under 800 lines, sharing one mock harness module) and apps.ts is now a 24-line barrel over launch/install/resolution/settings/device-io concerns — public import sites unchanged. 961 tests across handler + apple core suites and typecheck green locally. Note for the record: session-replay-vars.test.ts (2339 lines) still exceeds the bar but was NOT touched by this PR — pre-existing debt outside #1044's scope, fine to leave for its own pass. History tracing via --follow is inherently limited for one-into-many splits; the scenario file names are self-indexing, which matters more for agents anyway.
Coordinator re-review: no actionable blockers on current head 399bcc6. CI is green (21/21). The post-review CI fix only adjusts exported/internal split details, Android test timeout budget, and the fallow baseline after the session/apps split; it does not change the command surface or runtime routing intent. Merge-readiness is for maintainer judgment.
Coordinator re-check after rebase: current head 5dc3e98 is clean and CI is green (21/21). The PR remains ready-for-human; no new actionable blockers found after the base picked up #1057/#1058.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready-for-humanValid work that needs human implementation, judgment, or maintainer merge
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the 5.7k-line session handler test into focused scenario files backed by a shared mock harness, so each touched session file stays under 800 lines.
Split Apple app operations out of core/apps.ts into focused launch, install, resolution/inventory, settings, device I/O, and simctl helper modules while keeping core/apps.ts as the stable facade.
Closes #1044
Touched-file count: 20.
Validation
Ran the newly split session-handler suites: 11 files, 124 tests passed.
Ran Apple app-focused unit coverage for open/close/install/reinstall/resolve/deep-link/settings cases: 47 tests passed.
Ran provider lifecycle scenarios for iOS and macOS open/apps/appstate behavior: 2 files, 5 tests passed.
Ran pnpm format and pnpm check:quick.
Residual risk: the full src/platforms/apple/core/tests/index.test.ts suite still contains unrelated screenshot/status-bar cases that timed out or attempted xcrun outside the app split. The app-focused subset above passed.