fix: improve android fill verification diagnostics#495
Merged
Conversation
|
5560a25 to
11ad734
Compare
11ad734 to
9178676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve Android
fillverification diagnostics for IME-captured input and masked password fields.Details:
targetInput/actualInput, masked redaction, inferred password-node sensitivity, and expected/actual length metadata so other platforms can adopt the same contract.textRedactedmetadata.packageandpasswordattributes for fill diagnostics, and tighten Android IME ownership detection to input-method package/resource prefixes.input-actionsremains the action orchestrator.fill/typewhen diagnostics show Gboard handwriting/stylus capture.android-ime-capture-fixtureandfield-ime-capture-targetIDs, and point the SkillGym case at that fixture.Touched files: 11. Scope stayed within Android input verification, shared fill diagnostics, CLI help guidance, Agent Device Tester fixture coverage, and focused tests.
Validation
pnpm formatpnpm exec oxfmt --write examples/test-app/src/lab-state.tsx examples/test-app/src/screens/FormScreen.tsxpnpm exec vitest run src/platforms/android/__tests__/index.test.tspnpm exec vitest run src/platforms/__tests__/fill-diagnostics.test.ts src/platforms/android/__tests__/input-actions-fill.test.ts src/platforms/android/__tests__/index.test.tspnpm exec vitest run src/utils/__tests__/args.test.tspnpm check:fallow --base origin/mainpnpm buildpnpm check:quickpnpm test-app:installpnpm --dir examples/test-app typecheckpnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --case android-fill-ime-capture-stop-retry-loop --runner codex-miniKnown gap: full all-runner SkillGym invocation could not run here because the configured
clauderunner binary is missing from PATH (spawn claude ENOENT).