refactor: share android hierarchy metadata#497
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share Android UI hierarchy node metadata parsing so fill verification, bounds lookup, and snapshot tree parsing use one decoded attribute/bounds path.
Keep low-level XML attribute and bounds helpers private, avoiding a separate raw XML scan in fill verification.
Touched files: 3. Scope stayed within Android hierarchy/fill verification internals; no CLI syntax, docs, skills, or SkillGym changes were needed.
Validation
pnpm formatpnpm exec vitest run src/platforms/android/__tests__/input-actions-fill.test.ts src/platforms/android/__tests__/index.test.tspnpm check:quickpnpm check:fallow --base origin/mainpnpm build