fix: report blockers on wait timeout#546
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b46010ea0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| flags: { | ||
| ...params.req.flags, | ||
| snapshotInteractiveOnly: true, | ||
| snapshotCompact: true, | ||
| }, |
There was a problem hiding this comment.
Avoid reusing wait filters for blocker inspection
When a timed-out wait was invoked with selector snapshot filters such as --scope or --depth, this diagnostic snapshot inherits those same filters via ...params.req.flags. In the common blocker case where a permission dialog or modal appears outside the scoped subtree or below the requested depth, inspectCurrentSurface can return no labels/buttons (or a misleading root-only summary), so the new timeout message still fails to report the actual current surface. The post-timeout inspection should take an unscoped, sufficiently broad snapshot instead of carrying over the wait search filters.
Useful? React with 👍 / 👎.
026bf0d to
4478e46
Compare
4478e46 to
cd802d1
Compare
Summary
Add compact current-surface diagnostics to
waittimeout errors so agents can see likely visible blockers without dumping a full snapshot.Closes #534.
Details:
Before:
After:
Structured error details also include
currentSurface.labelsand, when available,currentSurface.buttons.Validation
pnpm exec vitest run src/daemon/handlers/__tests__/snapshot-handler.test.tspnpm check:quickpnpm check:unit