refactor: vendor png codec#609
Merged
Merged
Conversation
|
thymikee
force-pushed
the
codex/vendor-png-codec
branch
from
2b8e704 to
9b0eb20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the external
pngjsruntime dependency with a local PNG codec used by screenshot diff, resize, and overlay paths.The local codec preserves the existing
PNGsurface used in the repo, supports PNG filters, palette transparency, Adam7 interlace, CRC validation, and writes the 8-bit RGBA PNGs generated by agent-device. This removespngjsand@types/pngjsfrom package metadata.Touched files: 19. Scope stayed within PNG/screenshot utilities and tests.
Validation
Focused PNG/diff tests passed:
pnpm exec vitest run --project unit src/utils/__tests__/png.test.ts src/utils/__tests__/screenshot-diff.test.ts src/daemon/__tests__/screenshot-overlay.test.ts src/daemon/__tests__/request-router-screenshot.test.ts src/__tests__/cli-diff.test.ts src/__tests__/runtime-diff-screenshot.test.ts.Tooling passed with
pnpm check:tooling.Smoke tests passed outside the sandbox with
pnpm test:smoke.Manual iPhone 17 Pro Max simulator verification passed: captured baseline/current Settings screenshots, ran
agent-device diff screenshot, and produced/private/tmp/agent-device-png-verify/diff.pngwith 6.08% differing pixels. The verification session was closed.Full
pnpm check:unitwas attempted; the parallel suite hit an unrelated Android.aabinstall test timeout. Rerunning that exact test directly passed.