refactor: consolidate android gesture backend selection#689
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
refactor/android-touch-gesture-backends
branch
2 times, most recently
from
22324a1 to
a662c4c
Compare
thymikee
force-pushed
the
refactor/android-touch-gesture-backends
branch
from
a662c4c to
c3eb286
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates Android gesture backend selection into one internal helper while preserving provider-first execution, helper fallback, and swipe-only adb input fallback behavior.
Moves provider-native gesture routing coverage from a lower-level unit assertion into the provider-backed Android integration scenario, now covering swipe, pinch, rotate, and transform through the public daemon/client path.
Touched-file count: 3. Scope stayed within the Android touch helper module and its focused tests.
Validation
Verified the refactor with focused formatting, Android multitouch helper unit tests, provider-backed Android lifecycle integration, and quick repo validation:
pnpm exec oxfmt --write src/platforms/android/multitouch-helper.ts src/platforms/android/__tests__/multitouch-helper.test.ts test/integration/provider-scenarios/android-lifecycle.test.ts,pnpm exec vitest run src/platforms/android/__tests__/multitouch-helper.test.ts,pnpm exec vitest run --project provider-integration test/integration/provider-scenarios/android-lifecycle.test.ts, andpnpm check:quickall passed.