fix: recover depth-limited iOS snapshots after AX failures#706
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
fix/ios-depth-snapshot-ax-fallback
branch
from
859c817 to
bee3084
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depth-limited iOS snapshots now recover from XCTest accessibility serialization failures by returning a truncated fallback instead of failing the command outright. AX snapshot errors use the stable
IOS_AX_SNAPSHOT_FAILEDcontract with the existing serialization-tree message prefix, while preserving XCTest details such askAXErrorIllegalArgument.Flat compact-interactive snapshot output is now viewport-constrained. The AX fallback uses that same visible sparse path, queries actionable controls before high-cardinality text/image content, and keeps the recovery hint in the returned payload message so agents still get remediation guidance.
Touched files: 1.
Validation
Verified with
pnpm build:xcuitestfor both iOS simulator and macOS runner targets. Also rangit diff --check. Earlier manual Bluesky probing confirmed depth-limited snapshots return a truncated fallback where full root capture fails.