feat: add iOS device record support via runner#83
Merged
Conversation
|
thymikee
force-pushed
the
codex/ios-device-record
branch
from
c318258 to
c38c336
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add iOS physical-device support for record start|stop using the existing XCTest runner channel, and keep simulator (simctl) and Android (adb) recording behavior intact.
Harden runner recording stop/error handling, thread daemon/trace logging through iOS record calls, and add focused unit coverage for record pathways and close-with-active-recording cleanup.
Validation