This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Added Callstack's eslint + updated packages#10
Merged
Conversation
grabbou
reviewed
Sep 11, 2017
app/templates/_package.json
Outdated
| "jest": "^21.0.2", | ||
| "npm-release": "^1.0.0", | ||
| "prettier": "^0.22.0" | ||
| "prettier": "^1.6.1" |
Contributor
There was a problem hiding this comment.
I guess since we run eslint and eslint --fix, we don't need to directly depend on prettier anymore.
grabbou
suggested changes
Sep 11, 2017
Contributor
grabbou
left a comment
grabbou
left a comment
There was a problem hiding this comment.
Overall looks good. Just a tiny bit.
package.json
Outdated
| "husky": "^0.14.3", | ||
| "jest": "^21.0.2", | ||
| "lint-staged": "^4.1.3", | ||
| "prettier": "^1.6.1" |
Contributor
There was a problem hiding this comment.
Same here, no need to depend on prettier.
Contributor
Author
There was a problem hiding this comment.
I see. I thought that is a need for callstack's eslint. I will remove it then. 👍
jukben
force-pushed
the
feature/callstack-eslint
branch
from
3827251 to
a4cb21d
Compare
Contributor
Author
|
It's updated @grabbou |
grabbou
approved these changes
Sep 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #9