This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Running tests concurrently, ignoring tests folders in lib#5
Merged
Conversation
zamotany
suggested changes
Jun 16, 2017
app/templates/_package.json
Outdated
| "flow": "flow", | ||
| "lint": "eslint src", | ||
| "prepublish": "babel src --out-dir lib", | ||
| "prepublish": "babel src --out-dir lib --ignore '__tests__/'", |
Contributor
There was a problem hiding this comment.
I believe it should be --ignore **/__tests__/**
app/templates/_package.json
Outdated
| "prepublish": "babel src --out-dir lib --ignore '__tests__/'", | ||
| "jest": "jest src", | ||
| "test": "npm run flow && npm run lint && npm run jest", | ||
| "test": "concurrently \"npm run lint\" \"npm run flow\" \"npm run jest\"", |
Contributor
There was a problem hiding this comment.
What about having 2 commands: test and test:concurrency or maybe some shorthand like test:c??
The motivation behind this is that, CI usually use test command and it's better to have it running tasks in series, concurrent version should be a opt-in rather than forcing ppl to use that one.
rgommezz
force-pushed
the
template_enhancements
branch
from
4c393ea to
4952cd0
Compare
Contributor
Author
|
@zamotany done, let's merge for now the ignore flag for tests inside lib and I'll open up an issue to discuss the other points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.