fix: crash when initialising compiler and forks#646
Merged
Conversation
thymikee
reviewed
Sep 23, 2019
| __dirname, | ||
| transportServer.options.server.address(), | ||
| options | ||
| `localhost:${port}`, |
Member
There was a problem hiding this comment.
is setting this to hardcoded localhost is intended?
Contributor
Author
There was a problem hiding this comment.
Yes, I have to supply some host, and the host from transportServer is just :: which is invalid. This server will always run on the same machine and Haul main process. Even if the haul is run on different machine than the app or in a remote location the localhost should point to the same machine as Haul main process is running on.
thymikee
approved these changes
Sep 23, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
👍 calling init after constructor feels weird, and normally I'd advise to put some guards on any method of that class, but since this is only used in one place, I say meh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630