fix: Fixing bug that made masked view unresponsive after re-attaching#104
Merged
Naturalclar merged 1 commit intocallstack:masterfrom Feb 20, 2021
Merged
fix: Fixing bug that made masked view unresponsive after re-attaching#104Naturalclar merged 1 commit intocallstack:masterfrom
Naturalclar merged 1 commit intocallstack:masterfrom
Conversation
…attaching to window.
Contributor
Author
|
@Naturalclar This fixes a critical bug that was introduced by #98 , it would be great if this can be merged quickly 😄 |
Contributor
|
@tdekoning thanks for the ping! I'll try to take a look at this tonight |
Naturalclar
approved these changes
Feb 20, 2021
Contributor
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
@tdekoning thanks for the fix!
Naturalclar
changed the title
Contributor
|
This fix has been published in v0.2.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When including a masked-view in one route (using a library like react navigation), and the user navigates to a new route on the stack and presses the back button, the masked-view will not rerender any more.
The problem is that the bitmap invalidation does not happen when the view is attached to the window. Causing calls of React native to
dispatchDrawto not actually draw, keeping this component in a permanent state ofmBitmapMaskInvalidated = false;