Skip to content

fix: Xcode 12 compatibility#80

Merged
Naturalclar merged 1 commit intocallstack:nextfrom
Fetten:patch-1
Oct 30, 2020
Merged

fix: Xcode 12 compatibility#80
Naturalclar merged 1 commit intocallstack:nextfrom
Fetten:patch-1

Conversation

@Fetten
Copy link
Copy Markdown
Contributor

@Fetten Fetten commented Sep 18, 2020

Summary

The latest Xcode 12 fails to build when a module does not depend on React-Core directly. This change is necessary for all native modules on iOS. For details please see: facebook/react-native#29633 (comment)

Test Plan

  1. Build an App with Xcode 11.x. Result: The app builds.
  2. Build an App with Xcode 12. Result: The app will not build when depending on React.
  3. Build an App with Xcode 12 with the PR changes applied. Result: The app builds.

What's required for testing (prerequisites)?

Mac OS with Xcode 12

What are the steps to reproduce (after prerequisites)?

see Test Plan

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@Fetten
fix: Xcode 12 compatibility
f218a83 
The latest Xcode 12 fails to build when a module does not depend on `React-Core` directly. This change is necessary for all native modules on iOS. For details please see: facebook/react-native#29633 (comment)
@nacho-carnicero
Copy link
Copy Markdown

nacho-carnicero commented Oct 28, 2020

Hi, any chance this can be merged and released any time soon? Thank you!

@Naturalclar Naturalclar changed the base branch from master to next October 30, 2020 01:22
Naturalclar
Naturalclar approved these changes Oct 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fetten thanks!

@Naturalclar Naturalclar merged commit 5c2fe04 into callstack:next Oct 30, 2020
@afestein afestein mentioned this pull request Dec 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FonDorn FonDorn FonDorn approved these changes

+2 more reviewers

@alexisbronchart alexisbronchart alexisbronchart approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fetten @nacho-carnicero @FonDorn @alexisbronchart @Naturalclar