feat: Support more than 6 screens on Android #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9dae613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Just a couple of comments and we are good to merge!
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
okwasniewski
approved these changes
Apr 15, 2025
Member
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The default maximum number of screens allowed by Android's bottom navigation view is 6. I think the reasoning is to prevent people from over-populating the bottom tab bar. However, there are two situations that I can think of that require more than 6 tabs:
The goal isn't to make the nav bar look ugly, but provide more flexibility for "hidden" screens or custom tab bars.
How to test?
Update the example app to have more than 6 screens and see them all appear in the bottom tab bar. Make some screens hidden from the tab bar but still provide a way to navigate to them (maybe add a button on one of the screens that navigates to this "hidden" screen). You should see the native animation still works.
Screenshots