Skip to content

Conversation

@okwasniewski
Copy link
Member

This PR should close:

Api of the config plugin:

"plugins": [
      "react-native-bottom-tabs"
     // or 
     ["react-native-bottom-tabs", { theme: "material2" }]
 ],

@okwasniewski okwasniewski merged commit 0541da0 into main Oct 30, 2024
7 checks passed
@okwasniewski okwasniewski deleted the feat/config-plugin branch October 30, 2024 09:08
@fredrikburmester
Copy link

["react-native-bottom-tabs", { theme: "material2" }]

What themes are there to pick from?

@fredrikburmester
Copy link

Ah i found this: https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/android-native-styling.html

@fredrikburmester
Copy link

Another question, this does not seem to enable the native "pill" look on android. Is that not supported currently in the expo config? Thanks.

@okwasniewski
Copy link
Member Author

Another question, this does not seem to enable the native "pill" look on android. Is that not supported currently in the expo config? Thanks.

The pill is material3 theme which is the default. Just use ["react-native-bottom-tabs"] in the app.json file

@fredrikburmester
Copy link

fredrikburmester commented Nov 4, 2024

Screenshot 2024-11-04 at 22 07 32

I did, but i can't see the pill design.

@fredrikburmester
Copy link

@okwasniewski
Copy link
Member Author

Ah you also added edge-to-edge!

This library is missing material3 style, here is a feature request tracking it: zoontek/react-native-edge-to-edge#38

When it lands you should be able to remove bottom tabs config plugin as only one of them is needed to set the styling

@fredrikburmester
Copy link

Oh I did not know those were related, sorry. I'm confused as to why the edge-to-edge library needs the styles for the bottom-tabs to look like material3?

@okwasniewski
Copy link
Member Author

Oh I did not know those were related, sorry. I'm confused as to why the edge-to-edge library needs the styles for the bottom-tabs to look like material3?

Because edge to edge also changes the Android style in styles.xml

Now they change it to AppCompat but we need an option to change it to Material3. Android styles.xml is a bit wired but they base it on inheritance

@edmiquilena
Copy link

edmiquilena commented Nov 30, 2024

First of all, thanks for the lib!

I'm having the same problem with the "pill" not showing,
The style is shown as material 2
image
image
"@bottom-tabs/react-navigation": "^0.7.1" with expo SDK 52

Edit: Seems to be okay on prod builds, but on development build has no pill on selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expo config plugin Tab bar looks strange on Android (dark mode?)

4 participants