-
Notifications
You must be signed in to change notification settings - Fork 81
feat: introduce expo config plugin #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da61d99 to
78c5181
Compare
78c5181 to
e179fe5
Compare
What themes are there to pick from? |
|
Another question, this does not seem to enable the native "pill" look on android. Is that not supported currently in the expo config? Thanks. |
The pill is material3 theme which is the default. Just use ["react-native-bottom-tabs"] in the app.json file |
|
Ah you also added edge-to-edge! This library is missing material3 style, here is a feature request tracking it: zoontek/react-native-edge-to-edge#38 When it lands you should be able to remove bottom tabs config plugin as only one of them is needed to set the styling |
|
Oh I did not know those were related, sorry. I'm confused as to why the edge-to-edge library needs the styles for the bottom-tabs to look like material3? |
Because edge to edge also changes the Android style in styles.xml Now they change it to AppCompat but we need an option to change it to Material3. Android styles.xml is a bit wired but they base it on inheritance |



This PR should close:
Api of the config plugin: