Skip to content

refactor: rename brownie's __getStore global to __brownieGetStore to reduce 3p globals collision risk #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artus9033 merged 1 commit into from
Jan 15, 2026
Merged

refactor: rename brownie's __getStore global to __brownieGetStore to reduce 3p globals collision risk #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/brownie/cpp/BrownieInstaller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace brownie {

void BrownieInstaller::install(facebook::jsi::Runtime &runtime) {
auto getStore = facebook::jsi::Function::createFromHostFunction(
runtime, facebook::jsi::PropNameID::forAscii(runtime, "__getStore"), 1,
runtime, facebook::jsi::PropNameID::forAscii(runtime, "__brownieGetStore"), 1,
[](facebook::jsi::Runtime &rt, const facebook::jsi::Value &,
const facebook::jsi::Value *args, size_t count) -> facebook::jsi::Value {
if (count < 1 || !args[0].isString()) {
Expand All @@ -25,7 +25,7 @@ void BrownieInstaller::install(facebook::jsi::Runtime &runtime) {
return facebook::jsi::Object::createFromHostObject(rt, hostObject);
});

runtime.global().setProperty(runtime, "__getStore", getStore);
runtime.global().setProperty(runtime, "__brownieGetStore", getStore);
}

} // namespace brownie
2 changes: 1 addition & 1 deletion packages/brownie/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const stores = new Map<string, StoreCache>();

function getHostObject(key: string): HostObject {
// @ts-expect-error - untyped global prop set by BrownieInstaller.cpp
return global.__getStore?.(key);
return global.__brownieGetStore?.(key);
}

function getOrCreateStore(key: string): StoreCache {
Expand Down
Loading