Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes quicktype-* dependency ownership explicit in the monorepo by moving the runtime dependencies to the actual runtime package (@callstack/brownfield-cli) and removing/relocating them from packages where they’re not directly used.
Changes:
- Add
quicktype-coreandquicktype-typescript-inputtopackages/clidependencies (runtime owner for codegen). - Remove
quicktype-*frompackages/browniedependencies (no direct usage). - Move
quicktype-*from rootdependenciesto rootdevDependenciesto avoid implying runtime ownership at the repo root.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| yarn.lock | Updates lock metadata to reflect the dependency ownership move. |
| packages/cli/package.json | Declares quicktype-* as runtime dependencies where codegen imports occur. |
| packages/brownie/package.json | Removes unused direct quicktype-* dependencies. |
| package.json | Moves quicktype-* to root devDependencies to reflect non-runtime root usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thymikee
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quicktype-coreandquicktype-typescript-inputtopackages/clidependencies (actual runtime owner).quicktype-*frompackages/browniedependencies (not directly used there).quicktype-*from root dependencies to root devDependencies to avoid implying consumer/runtime ownership at monorepo root.The
quicktype-*are imported byBrowniecodegen implementation in@callstack/brownfield-cli(generateSwift / generateKotlin).When these deps are not declared by CLI, local workspace hoisting can mask the issue, but external consumers may need to install them manually.
This change makes dependency ownership explicit and reliable for published packages.
Test plan
CI passes - 🟢
Verified the changes from this PR and #239 - #240
Screen.Recording.2026-02-23.at.1.16.12.PM.mov