fix: support 16KB page sizes in Brownie#299
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Brownie Android native build configuration to enable support for 16KB memory page sizes, and adds a changeset to ship the fix as a patch release.
Changes:
- Adds the
ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZESCMake option to the AndroidexternalNativeBuildconfiguration. - Adds a Changesets entry to publish the update as a patch for
@callstack/brownie.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/brownie/android/build.gradle | Adjusts CMake configuration passed via Gradle for Android native builds. |
| .changeset/chubby-grapes-jog.md | Adds a patch changeset describing the 16KB page size support fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hurali97
approved these changes
Apr 10, 2026
Member
hurali97
left a comment
hurali97
left a comment
There was a problem hiding this comment.
Let's handle the copilot's review and then ship
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build Brownie Android with support for 16KB page sizes.
Test plan
CI green.