Skip to content

Conversation

@satya164
Copy link
Member

@satya164 satya164 commented Oct 31, 2025

Note

Updates the podspec template to include both Swift and C++ sources by default and revises conditional logic for nitro modules/view.

  • Podspec template (templates/native-common/{%- project.name %}.podspec):
    • Default (non-nitro): Use s.source_files = "ios/**/*.{h,m,mm,swift,cpp}"; set s.private_header_files when !project.swift.
    • Nitro modules/view: Use explicit arrays for ios Swift/ObjC and cpp sources; keep React-jsi and React-callinvoker dependencies; load autolinking script.
    • Logic change: Switch condition from || to && to decide default vs nitro branch.

Written by Cursor Bugbot for commit 74fa929. This will update automatically on new commits. Configure here.

@satya164 satya164 requested a review from Copilot October 31, 2025 15:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@satya164 satya164 merged commit ee2e134 into main Oct 31, 2025
21 checks passed
@satya164 satya164 deleted the @satya164/source-files branch October 31, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants