feat: create expo config plugin#313
Conversation
|
This PR depended on the upstream PR: thebergamo/react-native-fbsdk-next#205 |
thymikee
left a comment
There was a problem hiding this comment.
Thanks! I have no experience with expo plugins, hoping to find someone to review this properly
I found this package also require |
|
What's easiest for the Expo users? |
|
Because https://github.com/facebookarchive/react-native-fbsdk/blob/master/README.md |
Use |
|
Oh, then we should point to |
|
cc @EvanBacon for review |
EvanBacon
left a comment
There was a problem hiding this comment.
Looks good, pretty simple config plugin. Opt towards not having props if they're an empty object. Eventually we'll extend autolinking to support indicating that a config plugin has no properties and can be applied automatically when the native module is linked -- this would only work if the plugin has no required properties.
Co-authored-by: Evan Bacon <baconbrix@gmail.com>
EvanBacon
left a comment
There was a problem hiding this comment.
Looks great, nice work!
Thank you very much. Please assign any issue that related to Expo for me. I'm ready for help! |
|
Hi @thymikee, can you make a new release for this update? |
|
Published. Sorry for the delay |
Summary
Fixes #311
Test plan