Skip to content

Upgrade audience network to 4.22.1 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grabbou merged 1 commit into from
May 20, 2017
Merged

Upgrade audience network to 4.22.1 #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Readme.md → README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ $ cd ./example && npm start
### 3. Run it on iOS / Android

```bash
$ cd ./examples && npm run ios
$ cd ./examples && npm run android
$ cd ./example && npm run ios
$ cd ./example && npm run android
```

### Credits
Expand Down
2 changes: 1 addition & 1 deletion src/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ repositories {
dependencies {
compile 'com.facebook.react:react-native:+'
compile 'com.android.support:appcompat-v7:23.1.0'
compile 'com.facebook.android:audience-network-sdk:4.20.+'
compile 'com.facebook.android:audience-network-sdk:4.22.1'
}
5 changes: 5 additions & 0 deletions src/android/src/main/java/io/callstack/react/fbads/BannerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ public void onAdClicked(Ad ad) {
mEventEmitter.receiveEvent(getId(), "onAdPress", null);
}

@Override
public void onLoggingImpression(Ad ad) {
mEventEmitter.receiveEvent(getId(), "onLoggingImpression", null);
}

private void createAdViewIfCan() {
if (myAdView == null && mPlacementId != null && mSize != null) {
myAdView = new AdView(this.getContext(), mPlacementId, mSize);
Expand Down
4 changes: 4 additions & 0 deletions src/android/src/main/java/io/callstack/react/fbads/InterstitialAdManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ public void onInterstitialDisplayed(Ad ad) {

}

@Override
public void onLoggingImpression(Ad ad) {
}

private void cleanUp() {
mPromise = null;
mDidClick = false;
Expand Down