Skip to content

optimize(android): Remove unused code in cropAndResize() #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019
Merged

optimize(android): Remove unused code in cropAndResize() #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions android/src/main/java/com/reactnativecommunity/imageeditor/ImageEditorModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,18 +325,6 @@ private Bitmap cropAndResize(
// Loading large bitmaps efficiently:
// http://developer.android.com/training/displaying-bitmaps/load-bitmap.html

// Just decode the dimensions
BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
InputStream inputStream = openBitmapInputStream();
try {
BitmapFactory.decodeStream(inputStream, null, options);
} finally {
if (inputStream != null) {
inputStream.close();
}
}

// This uses scaling mode COVER

// Where would the crop rect end up within the scaled bitmap?
Expand All @@ -362,8 +350,7 @@ private Bitmap cropAndResize(
// Decode the bitmap. We have to open the stream again, like in the example linked above.
// Is there a way to just continue reading from the stream?
outOptions.inSampleSize = getDecodeSampleSize(mWidth, mHeight, targetWidth, targetHeight);
options.inJustDecodeBounds = false;
inputStream = openBitmapInputStream();
InputStream inputStream = openBitmapInputStream();

Bitmap bitmap;
try {
Expand Down