Skip to content

Conversation

@Sroka
Copy link
Contributor

@Sroka Sroka commented Jun 11, 2019

Summary

This library is using ContentProvider on Android as a mean to read image data and as such should accept all schemes handled by ContentProvider. Before this PR only URIs with file and content schemas were recognized as local URIs . This PR adds android.resource scheme what enables us to read apps resources.

Test Plan

  1. Try to read any app asset such as "android.resource:///drawable/.png"

What's required for testing (prerequisites)?

Adding some android asset to the app and trying to crop it.

What are the steps to reproduce (after prerequisites)?

  1. Try to read any app asset such as "android.resource:///drawable/.png"
    EX: User is able to read that asset
    AR: User is not able to read that asset

Compatibility

OS Implemented
Android

Checklist

  • [X ] I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@Trancever
Copy link
Contributor

@Sroka Awesome, thanks for PR!

@Trancever Trancever merged commit 0b036a4 into callstack:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants