Skip to content

fix: correct long label in outlined text input#2960

Merged
lukewalczak merged 1 commit intomainfrom
fix/long-label-input
Dec 10, 2021
Merged

fix: correct long label in outlined text input#2960
lukewalczak merged 1 commit intomainfrom
fix/long-label-input

Conversation

@lukewalczak
Copy link
Copy Markdown
Member

Summary

Fixes: #2954

PR adding a maxWidth for the label to correct the spacings after truncating and avoid displaying border.

Android iOS web
Zrzut ekranu 2021-11-5 o 13 41 10 Zrzut ekranu 2021-11-5 o 13 37 59 Zrzut ekranu 2021-11-5 o 13 44 22

Test plan

  1. Open the app
  2. Go to TextInput example
  3. Scroll to the example: Outlined with super long label which is truncating at some point
  4. Expect there is no border

@lukewalczak lukewalczak requested a review from brunohkbx November 5, 2021 12:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 5, 2021

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit c7bedca into main Dec 10, 2021
@lukewalczak lukewalczak deleted the fix/long-label-input branch December 10, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border appears in TextInput label when label is too long

2 participants