BottomBar: customizable inactive color

[jozan]

I really like BottomBar but it's not possible to customise inactive color at all. Are there any plans to support it or are there any objections if I send a PR?

I'm using BottomBar via react-navigation-material-bottom-tab-navigator.

References:

const inactiveColor = shifting
  ? textColor
  : color(textColor)
      .alpha(0.5)
      .rgb()
      .string();

https://github.com/callstack/react-native-paper/blob/master/src/components/BottomNavigation.js#L521

[satya164]

I'd merge a PR adding inactiveTintColor and activeTintColor props. Wanna do it?

[jozan]

Yes, I’ll start working on it in a few days once I’ve finished some other stuff.

…

On Sun, 13 May 2018 at 16.08, Satyajit Sahoo ***@***.***> wrote: I'd merge a PR adding inactiveTintColor and activeTintColor props. Wanna send a PR? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#366 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXsqVFYgsKS445oKWsla3GlhiSCMUj3ks5tyDBVgaJpZM4T8VbB> .

[jozan]

@satya164 Seem like you've already implemented this on 2.0. (#371)

https://github.com/callstack/react-native-paper/pull/371/files#diff-18fcf70e87723a21038fbb839fddd4a2R153