fix: elevation being applied after mode changes on a button while it shouldn't#1037
Merged
ferrannp merged 1 commit intocallstack:masterfrom May 9, 2019
jordy758:patch-1
Merged
fix: elevation being applied after mode changes on a button while it shouldn't#1037ferrannp merged 1 commit intocallstack:masterfrom jordy758:patch-1
ferrannp merged 1 commit intocallstack:masterfrom
jordy758:patch-1
Conversation
…le it shouldn't
|
Hey @jordy-wijman, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API. |
ferrannp
approved these changes
May 9, 2019
Collaborator
|
Thanks! |
Trancever
pushed a commit
that referenced
this pull request
May 9, 2019
iyadthayyil
pushed a commit
to iyadthayyil/react-native-paper
that referenced
this pull request
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The wrong elevation is being applied to an outlined button when it is first being rendered as a contained button.
Reproduce steps:
mode={this.propsIsContained ? 'contained' : 'outline'}and setpropsIsContained = 'true'.propsIsContained = falseWRONG
GOOD
FYI: duplicate of #1019 didn't know how to update that one.