Skip to content

Add contentContainerStyle to ModalProps interface#1052

Merged
ferrannp merged 3 commits intocallstack:masterfrom
Taym95:fix/contentContainerStyle
May 9, 2019
Merged

Add contentContainerStyle to ModalProps interface#1052
ferrannp merged 3 commits intocallstack:masterfrom
Taym95:fix/contentContainerStyle

Conversation

@Taym95
Copy link
Copy Markdown
Contributor

@Taym95 Taym95 commented May 6, 2019

Fix #1051

@callstack-bot
Copy link
Copy Markdown

callstack-bot commented May 6, 2019

Hey @Taym95, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@Taym95 Taym95 requested a review from Esemesek May 6, 2019 12:33
Comment thread typings/components/Modal.d.ts Outdated
onDismiss?: () => any;
visible: boolean;
children: React.ReactNode;
contentContainerStyle?: any;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to StyleProp<ViewStyle>?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import the types from react-native

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, My bad sorry!

@ferrannp ferrannp merged commit ff15100 into callstack:master May 9, 2019
@nzmedet
Copy link
Copy Markdown

nzmedet commented May 14, 2019

not published yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contentContainerStyle property to ModalProps interface

5 participants