fix: disable interaction when fading out modal#1116
Merged
ferrannp merged 1 commit intocallstack:masterfrom Jun 13, 2019
Merged
fix: disable interaction when fading out modal#1116ferrannp merged 1 commit intocallstack:masterfrom
ferrannp merged 1 commit intocallstack:masterfrom
Conversation
While the animation only last < 300ms, it is possible for user to interact with the modal during the transition. This is based on a fix suggested in facebook/react-native#6732
ferrannp
approved these changes
Jun 13, 2019
Collaborator
ferrannp
left a comment
ferrannp
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the animation only last < 300ms, it is still possible for user to interact with the modal during the transition.
This is based on a fix suggested in facebook/react-native#6732