Skip to content

fix: upgrade color missing changes #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-pawel merged 1 commit into from
Jul 19, 2019
+14 −7
Merged

fix: upgrade color missing changes #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Appbar/AppbarHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class AppbarHeader extends React.Component<Props> {
isDark =
backgroundColor === 'transparent'
? false
: !color(backgroundColor).light();
: !color(backgroundColor).isLight();
}
StatusBar.setBarStyle(isDark ? 'light-content' : 'dark-content');

Expand Down
18 changes: 12 additions & 6 deletions src/components/__tests__/Appbar/__snapshots__/Appbar.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ exports[`Appbar passes additional props to AppbarBackAction, AppbarContent and A
<View
accessibilityLabel="Back"
accessibilityRole="button"
accessibilityStates={Array []}
accessible={true}
hitSlop={
Object {
Expand All @@ -287,11 +288,13 @@ exports[`Appbar passes additional props to AppbarBackAction, AppbarContent and A
Array [
Object {
"alignItems": "center",
"borderRadius": 18,
"height": 36,
"justifyContent": "center",
"margin": 6,
"overflow": "visible",
"overflow": "hidden",
},
Object {
"borderRadius": 18,
"height": 36,
"width": 36,
},
undefined,
Expand Down Expand Up @@ -435,6 +438,7 @@ exports[`Appbar passes additional props to AppbarBackAction, AppbarContent and A
</View>
<View
accessibilityRole="button"
accessibilityStates={Array []}
accessible={true}
hitSlop={
Object {
Expand All @@ -459,11 +463,13 @@ exports[`Appbar passes additional props to AppbarBackAction, AppbarContent and A
Array [
Object {
"alignItems": "center",
"borderRadius": 18,
"height": 36,
"justifyContent": "center",
"margin": 6,
"overflow": "visible",
"overflow": "hidden",
},
Object {
"borderRadius": 18,
"height": 36,
"width": 36,
},
undefined,
Expand Down
1 change: 1 addition & 0 deletions src/components/__tests__/__snapshots__/Menu.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ exports[`renders menu with content styles 1`] = `
>
<View
accessibilityRole="button"
accessibilityStates={Array []}
accessible={true}
isTVSelectable={true}
onResponderGrant={[Function]}
Expand Down