fix: fixed backgroundColor of textinput label #3020#3038
Merged
lukewalczak merged 2 commits intocallstack:mainfrom Jan 14, 2022
Merged
fix: fixed backgroundColor of textinput label #3020#3038lukewalczak merged 2 commits intocallstack:mainfrom
lukewalczak merged 2 commits intocallstack:mainfrom
Conversation
Svarto
changed the title
lukewalczak
reviewed
Jan 13, 2022
| dense ? styles.densePatchContainer : styles.patchContainer, | ||
| { | ||
| backgroundColor: containerStyle.backgroundColor, | ||
| backgroundColor: viewStyle.backgroundColor || containerStyle.backgroundColor, |
Contributor
victoriomolina
left a comment
victoriomolina
left a comment
There was a problem hiding this comment.
This code cause might cause exceptions/issues. It should be:
-> {!isAndroid && multiline && Boolean(label) &&
-> backgroundColor: viewStyle.backgroundColor ?? containerStyle.backgroundColor,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #3020 , to ensure that the label in TextinputFlat aligns with the backgroundColor of the TextInput AND to not show the label if there is no label specified for the textInput.
Test plan
See issue, @lukewalczak ran tests and advised on this PR.