feat: adjust BottomNavigation#3083
Merged
lukewalczak merged 8 commits intonextfrom May 11, 2022
Merged
Conversation
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
force-pushed
the
feat/adjust-bottom-navigation
branch
from
0ec3fba to
9936468
Compare
lukewalczak
force-pushed
the
feat/adjust-bottom-navigation
branch
from
4b3e3a4 to
dbf7660
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
force-pushed
the
feat/adjust-bottom-navigation
branch
from
dbf7660 to
96a0ee9
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
2 similar comments
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
force-pushed
the
feat/adjust-bottom-navigation
branch
from
d4277db to
4aee358
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
OlimpiaZurek
approved these changes
Apr 19, 2022
Drakeoon
approved these changes
May 11, 2022
lukewalczak
added a commit
that referenced
this pull request
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR:
BottomNavigationinto Material You.compactindicating whether tabs should be spread across the entire width.navigationState.routes:icontofocusedIconunfocusedIconcolorTest plan
BottomNavigationworks and have correct colors in both themes on both platformsBottomNavigationworks properly in horizontal modeBottomNavigationfrom theme version 2 wasn't changed.