Skip to content

fix: pass maxFontSizeMultiplier to input label and adornments#3131

Merged
lukewalczak merged 1 commit intomainfrom
fix/text-input-max-font-size-multiplier
Mar 30, 2022
Merged

fix: pass maxFontSizeMultiplier to input label and adornments#3131
lukewalczak merged 1 commit intomainfrom
fix/text-input-max-font-size-multiplier

Conversation

@lukewalczak
Copy link
Copy Markdown
Member

Following the PR, but changing the approach previously introduced in BottomNavigation based on using maxFontSizeMultiplier rather the disabling font scale.

Summary

Passing maxFontSizeMutliplier from input to its adornments and labels.

ios android
Zrzut ekranu 2022-03-29 o 08 57 25 Zrzut ekranu 2022-03-29 o 09 22 09

Test plan

  • manual testing
  • unit tests covering maxFontSizeMultiplier use

@github-actions
Copy link
Copy Markdown

The mobile version of example app from this branch is ready! You can see it here

.

@lukewalczak lukewalczak merged commit 6299657 into main Mar 30, 2022
@lukewalczak lukewalczak deleted the fix/text-input-max-font-size-multiplier branch March 30, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant