feat: Snackbar support for any children#3412
Merged
lukewalczak merged 4 commits intomainfrom Oct 17, 2022
Merged
Conversation
|
The mobile version of example app from this branch is ready! You can see it here |
a278aa4 to
92a30cd
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
278366d to
92a30cd
Compare
…eat/snackbar-with-icon
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to snackbar to allow laying out it's non-text children gracefully, without overflowing the view. This effort fixes #3360.
Web
Android
iOS
Discussion:
With introducing these changes, we get the desired results without breaking the previous functionality. However, the text overflows behind the Undo button due to the icon view in snackbar.
This can be handled by the users by configuring the text styles like so:
Test plan
Unit test coverage and tested on Web, Android & iOS. (screenshots above)