chore: upgrade example app to expo 46 & update dependencies #3446
Conversation
|
Hey @slavikdenis, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here |
|
@lukewalczak Could you please review and merge this? |
| {React.Children.map(props.children, (child, i) => | ||
| React.isValidElement(child) | ||
| ? React.cloneElement(child, { | ||
| ? React.cloneElement<any>(child, { |
There was a problem hiding this comment.
I was thinking also about:
React.cloneElement(child as React.ReactElement<any>...
but don't have any strong preferences there.
src/core/Provider.tsx
Outdated
|
|
||
| if (!props.theme) { | ||
| subscription = addEventListener( | ||
| // @ts-expect-error |
There was a problem hiding this comment.
As above, it would be nice to add a short comment.
There was a problem hiding this comment.
|
The mobile version of example app from this branch is ready! You can see it here |
2 similar comments
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
|
The mobile version of example app from this branch is ready! You can see it here |
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
slavikdenis
force-pushed
the
3443-upgrade-expo-to-46-in-the-example-app
branch
from
c15941c to
ccf2656
Compare
|
The mobile version of example app from this branch is ready! You can see it here |
lukewalczak
left a comment
lukewalczak
left a comment
There was a problem hiding this comment.
Thanks for the help @slavikdenis!
Summary
Updating as many as possible dependencies & example app to expo 46.
Fixing or adding ts-expect-errors to typescript errors that have to be removed or solved in the future
Test plan
Tested running example app on Android, iOS & web. I didn't face any problems, please test as well.
Closes #3440