docs: apply brand color to the logo #3706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @yamankatby, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
lukewalczak
reviewed
Feb 27, 2023
| import ThemedImage from '@theme/ThemedImage'; | ||
| import useBaseUrl from '@docusaurus/useBaseUrl'; | ||
|
|
||
| <ThemedImage |
Member
There was a problem hiding this comment.
Do we need that ThemedImage? – asking because can't see where it's used
Collaborator
Author
There was a problem hiding this comment.
right in the 4th line
<ThemedImage
Member
There was a problem hiding this comment.
I see. Another thought, after specifying src and srcDark in navbar.logo do we need that ThemedImage?
Collaborator
Author
There was a problem hiding this comment.
The ThemedImage is used for the logo in the Home page. The src and srcDark is for the logo in the navbar.
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan